Skip to content

Call board_init before initing the on-board LEDs#4341

Closed
Neradoc wants to merge 1 commit into
adafruit:mainfrom
Neradoc:fix-neopixel-power
Closed

Call board_init before initing the on-board LEDs#4341
Neradoc wants to merge 1 commit into
adafruit:mainfrom
Neradoc:fix-neopixel-power

Conversation

@Neradoc
Copy link
Copy Markdown

@Neradoc Neradoc commented Mar 5, 2021

On the QT PY (M0 and 2040) there is a NEOPIXEL_POWER pin required to enable the neopixel. It is set in board_init, after the rgb_led_status_init (in main.c), too late for wait_for_safe_mode_reset to use the neopixel.

This PR moves the LED inits and safe mode related functions to after board_init().

@Neradoc
Copy link
Copy Markdown
Author

Neradoc commented Mar 6, 2021

Oh wait that won't work.
filesystem_init must be before board_init (because of SPI displays as stated by the comment in main.c).
board_init must be before wait_for_safe_mode_reset so the status LED can be used.
wait_for_safe_mode_reset must be before filesystem_init (uses safe_mode in an argument). (How did I miss that ?)
This needs a different type of solution.

@Neradoc Neradoc closed this Mar 6, 2021
@Neradoc Neradoc deleted the fix-neopixel-power branch March 12, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant